Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delay progress notfication closing from integration tests #3412

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 7, 2023

Should save ~25 seconds of run time every time the integration tests are run. That's ~50 seconds per commit passed to the CI. Savings add up.

@mattseddon mattseddon self-assigned this Mar 7, 2023
@mattseddon mattseddon marked this pull request as ready for review March 7, 2023 03:21
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@sroy3 sroy3 enabled auto-merge (squash) March 7, 2023 14:00
@codeclimate
Copy link

codeclimate bot commented Mar 7, 2023

Code Climate has analyzed commit b0ee3c9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 8728e94 into main Mar 7, 2023
@sroy3 sroy3 deleted the remove-progress-delay branch March 7, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants