Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vega-functions & vega-scale resolutions #3395

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 5, 2023

Trying to manually resolve #3388

@mattseddon mattseddon self-assigned this Mar 5, 2023
@mattseddon mattseddon changed the title Remove vega-functions resolution Remove vega-functions & vega-scale resolutions Mar 5, 2023
@mattseddon mattseddon force-pushed the remove-vega-resolution branch from f37f54b to 7e006ba Compare March 5, 2023 21:32
@mattseddon mattseddon force-pushed the remove-vega-resolution branch from 7e006ba to 71b0d6d Compare March 5, 2023 23:38
@mattseddon mattseddon marked this pull request as ready for review March 5, 2023 23:50
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mattseddon mattseddon enabled auto-merge (squash) March 6, 2023 17:39
@codeclimate
Copy link

codeclimate bot commented Mar 6, 2023

Code Climate has analyzed commit 32a20e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.8%.

View more on Code Climate.

@mattseddon mattseddon merged commit c83eb2a into main Mar 6, 2023
@mattseddon mattseddon deleted the remove-vega-resolution branch March 6, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants