Add Studio settings page #3379
Merged
Add Studio settings page #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import { EmptyState } from '../../shared/components/emptyState/EmptyState' | ||
| import { Button } from '../../shared/components/button/Button' | ||
|
|
||
| export const Studio: React.FC = () => { | ||
| const Connect: React.FC = () => { |
There was a problem hiding this comment.
Function Connect has 41 lines of code (exceeds 30 allowed). Consider refactoring.
mattseddon
force-pushed
the
add-studio-settings-page
branch
from
1e4d6ca to
27144c1
Compare
mattseddon
force-pushed
the
add-studio-settings-page
branch
2 times, most recently
from
7aa6377 to
b7d81f9
Compare
mattseddon
force-pushed
the
add-live-share-studio
branch
from
e92150a to
e0a8220
Compare
mattseddon
force-pushed
the
add-studio-settings-page
branch
from
b7d81f9 to
244fbed
Compare
sroy3
approved these changes
Mar 3, 2023
mattseddon
force-pushed
the
add-studio-settings-page
branch
from
244fbed to
0b37d00
Compare
|
Code Climate has analyzed commit 0b37d00 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 93.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #3387 <- thisThis PR adds a studio settings page and wires it up with the sidebar once Studio is connected.
Demo
E2E Flow
Screen.Recording.2023-03-03.at.1.26.47.pm.mov
View checkbox updates config
Screen.Recording.2023-03-03.at.1.15.20.pm.mov
Notes:
I played around with adding different buttons on the LHS a lot but there is no room/not enough text to provide all of the required details. Whatever is there seems very vague, this seems like the best option for now.
There really isn't much to add into a settings page at the moment but this moves in that general direction.
I also adjusted the approach based on feedback provided in #3378.