-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share experiment to Studio from experiments table #3289
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
342f331
create prototype for sharing experiments from the experiments table t…
mattseddon 8460065
add tests
mattseddon e0d0578
refactor code
mattseddon ea56dc4
self review
mattseddon c7a9768
rearrange code to fit existing structure
mattseddon 0431783
fix package json entries
mattseddon ee43de2
move command out of register
mattseddon 393dd83
send correct params
mattseddon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
import { Progress } from 'vscode' | ||
import { Progress, commands } from 'vscode' | ||
import { AvailableCommands, InternalCommands } from '../../commands/internal' | ||
import { Toast } from '../../vscode/toast' | ||
import { WorkspaceExperiments } from '../workspace' | ||
import { Connect } from '../../connect' | ||
import { RegisteredCommands } from '../../commands/external' | ||
|
||
export const getBranchExperimentCommand = | ||
(experiments: WorkspaceExperiments) => | ||
|
@@ -104,3 +106,19 @@ export const getShareExperimentAsCommitCommand = | |
return Toast.delayProgressClosing() | ||
}) | ||
} | ||
|
||
export const getShareExperimentToStudioCommand = | ||
(internalCommands: InternalCommands, connect: Connect) => | ||
async ({ dvcRoot, id }: { dvcRoot: string; id: string }) => { | ||
const studioAccessToken = await connect.getStudioAccessToken() | ||
if (!studioAccessToken) { | ||
return commands.executeCommand(RegisteredCommands.CONNECT_SHOW) | ||
} | ||
|
||
return internalCommands.executeCommand( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [F] See this comment for an explanation of how "exp push" is currently implemented in the extension. |
||
AvailableCommands.EXP_PUSH, | ||
studioAccessToken, | ||
dvcRoot, | ||
id | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] v2 is the commonJS implementation