Clean up webview factory #3277
Merged
Clean up webview factory #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Feb 14, 2023
extension/src/webview/factory.ts
Outdated
| const isValidDvcRoot = (dvcRoot?: string): dvcRoot is string => !!dvcRoot | ||
|
|
||
| const needsDvcRoot = (viewKey: ViewKey): boolean => | ||
| ![ViewKey.CONNECT, ViewKey.SETUP].includes(viewKey) |
There was a problem hiding this comment.
[F] I think this is ok because the factory already knows about the type of webviews it is creating.
mattseddon
force-pushed
the
update-factory
branch
from
75c4fed to
5292c2d
Compare
mattseddon
commented
Feb 14, 2023
| await view.isReady() | ||
| return view | ||
| } | ||
|
|
||
| export const restoreWebview = <T extends WebviewData>( |
There was a problem hiding this comment.
[F] This is a relic from a previous feature.
sroy3
approved these changes
Feb 14, 2023
mattseddon
force-pushed
the
update-factory
branch
from
5292c2d to
8b4e7e9
Compare
mattseddon
force-pushed
the
update-factory
branch
from
8b4e7e9 to
7ea72df
Compare
mattseddon
force-pushed
the
update-factory
branch
from
7ea72df to
4104496
Compare
|
Code Climate has analyzed commit 4104496 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #3235 <- thisFollow up from this comment. Simplifies/cleans up the webview factory.