Add checkout inline to SCM view #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Apr 26, 2021
| @@ -16,6 +17,7 @@ const runTargetCommand = async ( | |||
|
|
|||
| const target = basename(fsPath) | |||
| const commandWithTarget = buildCommand(command, target) | |||
| await ensureDir(cwd) | |||
There was a problem hiding this comment.
[F] There was a bug causing the underlying command to fail if the whole directory had been deleted.
mattseddon
commented
Apr 26, 2021
| @@ -112,31 +111,6 @@ describe('checkout', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('checkoutRecursive', () => { | |||
There was a problem hiding this comment.
[F] This is the default behaviour of checkout when a target is not specified.
… add-checkout-inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds removes
checkoutRecursive, replaces it withcheckoutTargetand wires upcheckoutandcheckoutTargetwith our SCM view (as per #318).Another screen recording below
Screen.Recording.2021-04-26.at.3.51.21.pm.mov
As you can see I used the "discard" icon to try and fit in with the git extension. I also added the command inline into the scm/title to show that we can do this. That is prime real estate so we'll have to decide the most commonly used functions to go in there.
LMK if you have any questions.