Rename files associated with LSP #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
rename-lsp-files
branch
from
be99a1c to
1d16913
Compare
|
Related to #2529 |
sroy3
approved these changes
Jan 31, 2023
mattseddon
force-pushed
the
rename-lsp-files
branch
from
51d0420 to
5b2cbcd
Compare
|
Code Climate has analyzed commit 5b2cbcd and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 89.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #3175 <- thisThis PR cleans up some of the naming in the files associated with our language server. I have also converted the
TextDocumentWrapperto a set of functions as it didn't really make sense to grab all of the documents and then wrap them each time we try to access them. This might make sense again in the future (and we can change again).