Use process polling to ensure DVCLive only PIDs are still running #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jan 4, 2023
| pollSignalFileForProcess(this.dvcLiveOnlySignalFile, () => { | ||
| this.dvcLiveOnlyCleanupInitialized = false | ||
| if (this.hasRunningExperiment()) { | ||
| this.cliData.update() |
There was a problem hiding this comment.
[F] The signal file has now been removed so we request the data again to flush out the fact that an experiment is no longer running.
sroy3
approved these changes
Jan 4, 2023
|
Code Climate has analyzed commit 3ebec90 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.5%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2991 by addressing:
Demo
Screen.Recording.2023-01-04.at.12.21.39.pm.mov