-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exp tree tooltips and quick pick selection ignoring columns with falsy values #2745
Merged
julieg18
merged 6 commits into
main
from
fix-exp-tree-tooltips-and-exp-select-ignoring-0
Nov 9, 2022
Merged
Fix exp tree tooltips and quick pick selection ignoring columns with falsy values #2745
julieg18
merged 6 commits into
main
from
fix-exp-tree-tooltips-and-exp-select-ignoring-0
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Nov 8, 2022
julieg18
changed the title
Fix exp tree tooltips and quick pick selection ignoring 0 values
Fix exp tree tooltips and quick pick selection ignoring columns with a value of 0
Nov 8, 2022
sroy3
approved these changes
Nov 8, 2022
julieg18
changed the title
Fix exp tree tooltips and quick pick selection ignoring columns with a value of 0
Fix exp tree tooltips and quick pick selection ignoring columns with falsy values
Nov 8, 2022
Code Climate has analyzed commit 8d230e2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our code will not show a column if its collected value is "falsy", which means it ignores columns with falsy values.
Current:
PR: