Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exp tree tooltips and quick pick selection ignoring columns with falsy values #2745

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Nov 8, 2022

Currently our code will not show a column if its collected value is "falsy", which means it ignores columns with falsy values.

Current:

image

PR:

image

@julieg18 julieg18 added the bug Something isn't working label Nov 8, 2022
@julieg18 julieg18 self-assigned this Nov 8, 2022
@julieg18 julieg18 changed the title Fix exp tree tooltips and quick pick selection ignoring 0 values Fix exp tree tooltips and quick pick selection ignoring columns with a value of 0 Nov 8, 2022
@julieg18 julieg18 marked this pull request as ready for review November 8, 2022 16:12
extension/src/experiments/model/util.ts Outdated Show resolved Hide resolved
@julieg18 julieg18 marked this pull request as draft November 8, 2022 23:08
@julieg18 julieg18 changed the title Fix exp tree tooltips and quick pick selection ignoring columns with a value of 0 Fix exp tree tooltips and quick pick selection ignoring columns with falsy values Nov 8, 2022
@julieg18 julieg18 marked this pull request as ready for review November 9, 2022 16:39
@julieg18 julieg18 closed this Nov 9, 2022
@julieg18 julieg18 reopened this Nov 9, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 9, 2022

Code Climate has analyzed commit 8d230e2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 enabled auto-merge (squash) November 9, 2022 18:22
@julieg18 julieg18 merged commit 7de2c6b into main Nov 9, 2022
@julieg18 julieg18 deleted the fix-exp-tree-tooltips-and-exp-select-ignoring-0 branch November 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants