Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages to fix terser vulnerability #2652

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Oct 21, 2022

Fixes terser vulnerability

@sroy3 sroy3 added the bug Something isn't working label Oct 21, 2022
@sroy3 sroy3 self-assigned this Oct 21, 2022
@sroy3 sroy3 marked this pull request as ready for review October 21, 2022 15:47
Copy link
Member

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC this resolution broke the build or dev-server for me

@sroy3
Copy link
Contributor Author

sroy3 commented Oct 21, 2022

IIRC this resolution broke the build or dev-server for me

Works great for me. This replaced only one instance of [email protected] (might have been more when you last tried) found in webpack and all webpack related tasks still work.

@sroy3 sroy3 enabled auto-merge (squash) October 21, 2022 20:04
@codeclimate
Copy link

codeclimate bot commented Oct 21, 2022

Code Climate has analyzed commit 01d1839 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit ed218ab into main Oct 21, 2022
@sroy3 sroy3 deleted the fix-terser-vulnerability branch October 21, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants