Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not toggle plot section when clicking a link #2632

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Do not toggle plot section when clicking a link #2632

merged 2 commits into from
Oct 19, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Oct 19, 2022 •
edited
Loading

Screen.Recording.2022-10-19.at.10.11.07.AM.mov

@sroy3 sroy3 added the bug Something isn't working label Oct 19, 2022
@sroy3 sroy3 self-assigned this Oct 19, 2022
@sroy3 sroy3 marked this pull request as ready for review October 19, 2022 14:37
@sroy3 sroy3 requested a review from shcheklein October 19, 2022 14:37
@sroy3
Copy link
Contributor Author

sroy3 commented Oct 19, 2022

You were right @shcheklein, stopPropagation had some weird effect. Either it was stringified or changed the context of the link.

julieg18
julieg18 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@sroy3 sroy3 enabled auto-merge (squash) October 19, 2022 17:22
@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit b31475e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit a501e6b into main Oct 19, 2022
@sroy3 sroy3 deleted the no-toggle-on-link branch October 19, 2022 17:30
shcheklein
shcheklein reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sroy3 for improving the experience! From what I can see we probably need to test that element doesn't belong the tooltip container (?) to completely fix this (now it's still reacts if you click on the tooltip (not link)).

@sroy3
Copy link
Contributor Author

sroy3 commented Oct 20, 2022

Thanks @sroy3 for improving the experience! From what I can see we probably need to test that element doesn't belong the tooltip container (?) to completely fix this (now it's still reacts if you click on the tooltip (not link)).

Will try doing it

@sroy3 sroy3 mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein left review comments

@julieg18 julieg18 julieg18 approved these changes

@mattseddon mattseddon Awaiting requested review from mattseddon mattseddon is a code owner

Assignees

@sroy3 sroy3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sroy3 @shcheklein @julieg18