Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only patch workspace only calls to plots diff #2629

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Oct 19, 2022

Address one of the points from #2581

Plots update command runs with extra arguments for no reason.

From #2581 (comment):

The last item can be narrowed down to this:

public getDefaultRevs() {
return ['workspace', ...Object.values(this.branchRevisions)]
}

and this PR:

https://github.com/iterative/vscode-dvc/pull/1949/files

One the issue is fixed now.

Btw, using the workspace revision alone gives me an error (I would expect this, since workspace is not an actual Git revision):

plots,diff,workspace,-o,.dvc/tmp/plots,--split,--json failed with ERROR: unknown Git revision 'workspace' retrying...

I am reluctant to unwind any of the changes made in #1949 right now and they are unrelated to this particular change.

In order to get significant performance increases we will need to re-do this sub-system and we will need help from the CLI.

@mattseddon mattseddon added the bug Something isn't working label Oct 19, 2022
@mattseddon mattseddon self-assigned this Oct 19, 2022
@mattseddon mattseddon marked this pull request as ready for review October 19, 2022 05:25
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mattseddon mattseddon enabled auto-merge (squash) October 19, 2022 18:30
@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit e3d1d35 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 0fb7275 into main Oct 19, 2022
@mattseddon mattseddon deleted the ask-for-less-revisions branch October 19, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants