Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split standardize path into two functions #2627

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Oct 19, 2022

2/2 main <- #2624 <- this

This PR address this comment.

@mattseddon mattseddon self-assigned this Oct 19, 2022
@mattseddon mattseddon changed the base branch from main to demo-submodule October 19, 2022 02:05
@mattseddon mattseddon marked this pull request as ready for review October 19, 2022 02:10
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon force-pushed the fix-function-types branch 2 times, most recently from b079f6f to 0001101 Compare October 19, 2022 19:08
Base automatically changed from demo-submodule to main October 19, 2022 19:38
@mattseddon mattseddon enabled auto-merge (squash) October 19, 2022 19:39
@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit 44fdff8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8%.

View more on Code Climate.

@mattseddon mattseddon merged commit 8374d66 into main Oct 19, 2022
@mattseddon mattseddon deleted the fix-function-types branch October 19, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants