Add webpack dummy build as a lint step #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
reviewed
Oct 19, 2022
webview/package.json
Outdated
| @@ -7,6 +7,7 @@ | |||
| "lint:prettier": "prettier -c '**/*.{js,json,jsx,md,scss,ts,tsx,yaml,yml}'", | |||
| "lint:eslint": "eslint --cache '**/*.{js,ts,jsx,tsx}'", | |||
| "lint:tsc": "tsc --noEmit", | |||
| "lint:webpack": "webpack --mode development", | |||
There was a problem hiding this comment.
[Q] Do we need lint:tsc if we have this? Could we change to lint:compile for all sub-projects? Leave extension as is but change the two sub-projects bundled by webpack to use this?
There was a problem hiding this comment.
That's a good point, thanks! I'll add lint:compile to the two webpacked projects and remove lint:tsc from them
wolmir
force-pushed
the
webpack-linting-step
branch
from
56b43c3 to
f515691
Compare
|
Code Climate has analyzed commit f515691 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
sroy3
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add webpack --mode development as a linting step.
The objective is to catch bundling errors that tsc --no-emit ignores, like styles.scss imports, for example.