Add util for identifying ValueTree type #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
add-object-util
branch
from
4cc5ea6 to
cee88a6
Compare
mattseddon
force-pushed
the
add-object-util
branch
from
cee88a6 to
6ac8c24
Compare
mattseddon
force-pushed
the
add-object-util
branch
from
6ac8c24 to
9101713
Compare
|
Code Climate has analyzed commit 9101713 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
sroy3
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First follow-up from #2617.
Seems like we need to do the same check in a few different places, I considered adding a more general object util but this is what we need for now.
This is not something that I'll forget in a hurry.