Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload vsix as part of publish action #2615

Merged
merged 5 commits into from
Oct 18, 2022
Merged

Upload vsix as part of publish action #2615

merged 5 commits into from
Oct 18, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Oct 17, 2022

See https://iterativeai.slack.com/archives/C01RB7BTG4C/p1666046325944219?thread_ts=1666044263.449979&cid=C01RB7BTG4C

As part of trying to recover from this error, I had to build the VSIX locally. This PR adds an upload step so that the VSIX built by the CI will always be available.

Example of a CI run including the same upload action: https://github.com/iterative/vscode-dvc/actions/runs/3269609097 from aef55ec

@mattseddon mattseddon force-pushed the add-vsix-upload branch 2 times, most recently from eb9c2be to 158217a Compare October 18, 2022 00:04
@mattseddon mattseddon marked this pull request as ready for review October 18, 2022 00:24
@mattseddon mattseddon enabled auto-merge (squash) October 18, 2022 17:21
@codeclimate
Copy link

codeclimate bot commented Oct 18, 2022

Code Climate has analyzed commit 7b709e2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8%.

View more on Code Climate.

@mattseddon mattseddon merged commit fda88ae into main Oct 18, 2022
@mattseddon mattseddon deleted the add-vsix-upload branch October 18, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants