Fix experiment table changes collection bug #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Oct 15, 2022
| let workspace | ||
| let currentCommit | ||
|
|
||
| for (const [key, value] of Object.entries(data)) { |
There was a problem hiding this comment.
This would not return the correct data now there are > 2 entries in the exp show data. It would actually return the oldest commit
mattseddon
commented
Oct 16, 2022
| @@ -109,7 +110,7 @@ const collectChange = ( | |||
| commitData: ExperimentFields, | |||
| ancestors: string[] = [] | |||
| ) => { | |||
| if (typeof value === 'object') { | |||
| if (!Array.isArray(value) && typeof value === 'object') { | |||
There was a problem hiding this comment.
[F] If we get to an array we want to compare the array, not try to walk it.
|
Code Climate has analyzed commit 3009a26 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8%. View more on Code Climate. |
sroy3
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a couple of issues with the code whilst staring at it after reading #2569 (comment).