Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table drag and drop implementation #2566

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Oct 11, 2022

  • have columns change on column drop instead of on column drag

Demo

Screen.Recording.2022-10-14.at.6.44.20.PM.mov

Fixes #2421

@julieg18 julieg18 added the product PR that affects product label Oct 11, 2022
@julieg18 julieg18 self-assigned this Oct 11, 2022
@julieg18 julieg18 force-pushed the update-experiments-table-dnd branch from 0acb35f to 129088e Compare October 14, 2022 23:40
@julieg18 julieg18 changed the title Update table dnd implementation (WIP) Update table drag and drop implementation Oct 17, 2022
@julieg18 julieg18 marked this pull request as ready for review October 17, 2022 23:30
Copy link
Member

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: esc works to cancel d'n'd

@mattseddon mattseddon requested a review from shcheklein October 18, 2022 00:40
@shcheklein
Copy link
Member

Thanks @julieg18 !

Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2022

Code Climate has analyzed commit 4eb3c79 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 3

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit c7c181b into main Oct 18, 2022
@julieg18 julieg18 deleted the update-experiments-table-dnd branch October 18, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table DnD: there should be a way to get back to the initial state / cancel
4 participants