Make the plot sizes use numbers underneath #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2022 13:34
added 2 commits
October 11, 2022 11:43
…scode-dvc into numerical-plot-sizes
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
reviewed
Oct 15, 2022
| @@ -11,7 +11,7 @@ export const ComparisonTableWrapper: React.FC = () => { | |||
| const { size, isCollapsed } = useSelector( | |||
| (state: PlotsState) => state.comparison | |||
| ) | |||
| const handleResize = (size: PlotSize) => { | |||
| const handleResize = (size: number) => { | |||
There was a problem hiding this comment.
[C] Seems like there are three versions of the same handleResize wrapper function.
There was a problem hiding this comment.
It's because they are dispatching 3 different actions (they share the same name, but are imported from different files).
mattseddon
approved these changes
Oct 15, 2022
|
Will wait to merge until more work for the grid is lined up |
|
Code Climate has analyzed commit b349389 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2585
Screen.Recording.2022-10-11.at.1.28.19.PM.mov