Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min tested version of DVC to 2.28.0 #2488

Merged
merged 8 commits into from
Sep 28, 2022
Merged

Bump min tested version of DVC to 2.28.0 #2488

merged 8 commits into from
Sep 28, 2022

Conversation

mattseddon
Copy link
Member

No description provided.

@mattseddon mattseddon self-assigned this Sep 28, 2022
@mattseddon mattseddon marked this pull request as ready for review September 28, 2022 10:45
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon force-pushed the bump-min-tested branch 2 times, most recently from 6ea9639 to 93eac0d Compare September 28, 2022 22:15
@codeclimate
Copy link

codeclimate bot commented Sep 28, 2022

Code Climate has analyzed commit f71cc0f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.0% change).

View more on Code Climate.

@mattseddon
Copy link
Member Author

This failed a lot of times because there were experiments on a previous commit that plots diff was trying to find (not possible because they were never pushed to the remote). I will update the e2e tests to remove experiments from previous commits.

@mattseddon mattseddon merged commit cb9ecc1 into main Sep 28, 2022
@mattseddon mattseddon deleted the bump-min-tested branch September 28, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants