Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining data update watchers to RelativePatterns #2451

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Sep 23, 2022

(Unlikely but) possible cause of live updates not working for plots on Codespaces.

Follows on from #1905

@mattseddon mattseddon self-assigned this Sep 23, 2022
@mattseddon mattseddon marked this pull request as ready for review September 23, 2022 04:21
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codeclimate
Copy link

codeclimate bot commented Sep 23, 2022

Code Climate has analyzed commit 33a6e40 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 37.5% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit afb400a into main Sep 23, 2022
@mattseddon mattseddon deleted the move-watchers-to-relative branch September 23, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants