Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra background color from the table view #2425

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

shcheklein
Copy link
Member

Motivation:

  • make it more VS Code style (editors don't have an extra delimiter). It feels like there are two open tabs, and even in that case it's not right since background is from menu, not from editors, panels
  • make less visually noisy

Before:

Screen.Recording.2022-09-17.at.6.03.46.PM.mov

After:

Screen.Recording.2022-09-17.at.7.19.51.PM.mov

@shcheklein shcheklein added A: experiments Area: experiments table webview and everything related product PR that affects product labels Sep 18, 2022
@shcheklein shcheklein requested a review from maxagin September 18, 2022 02:23
@mattseddon mattseddon force-pushed the remove-extra-background branch from 692f90a to 17ec51f Compare September 18, 2022 09:40
@mattseddon mattseddon enabled auto-merge (squash) September 18, 2022 09:41
@mattseddon mattseddon changed the title Remove extra background from the table view Remove extra background color from the table view Sep 18, 2022
@codeclimate
Copy link

codeclimate bot commented Sep 18, 2022

Code Climate has analyzed commit 17ec51f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 97.0% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 08131a5 into main Sep 18, 2022
@mattseddon mattseddon deleted the remove-extra-background branch September 18, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants