Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min version of DVC to 2.23.0 (--with-dirs removed from data status) #2299

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 30, 2022

5/5 main <- #2091 <- #2151 <- #2266 <- #2267 <- this

This PR removes the use of a --with-dirs from our call to data status. The flag was removed in 2.23.0 in favour of having that as the default behaviour.

@sroy3
Copy link
Contributor

sroy3 commented Aug 31, 2022

Is #2266 needed then if you're going to merge this into it?

Base automatically changed from consume-unknown to main September 1, 2022 00:07
@mattseddon mattseddon force-pushed the avoid-breaking-change branch from 4158bf5 to 2f5d269 Compare September 1, 2022 00:10
@mattseddon mattseddon enabled auto-merge (squash) September 1, 2022 00:11
@codeclimate
Copy link

codeclimate bot commented Sep 1, 2022

Code Climate has analyzed commit 2f5d269 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 0c60fcb into main Sep 1, 2022
@mattseddon mattseddon deleted the avoid-breaking-change branch September 1, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants