Improve table styles #2289
Improve table styles #2289
Conversation
* add tooltips to row actions * take off first cell right border when cell is sticky * increase workspace row height * take off right border on last header children * update column resizer hover background color
|
@julieg18 what happens at ~10 seconds of the video? From watching the whole video I can assume that selecting the row removes the stickiness of the first column. This looks broken to me. |
Yes, selecting the row turns off the stickiness. It's always been like that though (picture below was taken on the latest extension release):
Agreed though, it does look buggy... I can look into keeping selected rows sticky if we'd like! |
Please share the updated version, when you have it. Thank you @julieg18 |
|
Good work @julieg18
Use the full height of the cell (also I have a feeling the blue line has opacity. Right?):
|
|
In relation to the
|
|
Just FYI. The selected first cell does not have a shadow:
|
|
Q: is the blue border when on hover 2px?
|
Correct! I'll take the opacity off. Not sure if I can make the lines the full height of the cell though, will need to look into it a bit more 🤔
Yes, it is 2px! |
|
Code Climate has analyzed commit fc48e40 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9% (0.0% change). View more on Code Climate. |
|
Ok, merged #2294 which fixed the none sticky selected rows issue! Also, per @maxagin comments, added opacity to the resizer bar and took off the borders when the header cells are sticky since those were both pretty simple fixes. Video is updated and I think we're good to merge once tests are passing! |
|
Looks like "The selected first cell does not have a shadow" also was fixed :) #2289 (comment) |
Demo
Screen.Recording.2022-08-30.at.10.30.04.AM.mov
Part of #2241