Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Timestamp" column label to "Created" #2269

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Aug 26, 2022

Renames the timestamp column's name to "Created", matching DVC CLI tables.

Main:

image

PR:

image

Followup to #2239 comment

@julieg18 julieg18 added the product PR that affects product label Aug 26, 2022
@julieg18 julieg18 self-assigned this Aug 26, 2022
@julieg18 julieg18 marked this pull request as ready for review August 26, 2022 14:03
@julieg18 julieg18 requested review from shcheklein and maxagin August 26, 2022 14:03
@maxagin
Copy link
Contributor

maxagin commented Aug 26, 2022

@julieg18, @shcheklein Shouldn't we request the DVC team change it since the Timestamp term is more efficient?

@mattseddon
Copy link
Member

@julieg18, @shcheklein Shouldn't we request the DVC team change it since the Timestamp term is more efficient?

"Timestamp" does not tell you what the timestamp represents. Created does.

@codeclimate
Copy link

codeclimate bot commented Aug 29, 2022

Code Climate has analyzed commit 7762c52 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@julieg18
Copy link
Contributor Author

Going to go ahead and merge this! We can always revert if we decide that we want to keep the "Timestamp" name :)

@julieg18 julieg18 merged commit 07a2f2a into main Aug 29, 2022
@julieg18 julieg18 deleted the rename-timestamp-column-to-created branch August 29, 2022 14:18
@maxagin
Copy link
Contributor

maxagin commented Aug 29, 2022

@julieg18, @shcheklein Shouldn't we request the DVC team change it since the Timestamp term is more efficient?

"Timestamp" does not tell you what the timestamp represents. Created does.

A timestamp is a digital record of the time of occurrence of a particular event.

@shcheklein
Copy link
Member

@maxagin if we want to change this, let's raise an issue in the DVC repo first please. My take both are fine for now, there are pros and cons, so let's keep it at move forward.

@mattseddon
Copy link
Member

A timestamp is a digital record of the time of occurrence of a particular event.

Which event? When the experiment was created, when it was first modified, when it was last modified, when it was completed, last time it was selected?

@maxagin
Copy link
Contributor

maxagin commented Aug 30, 2022

A timestamp is a digital record of the time of occurrence of a particular event.

Which event? When the experiment was created, when it was first modified, when it was last modified, when it was completed, last time it was selected?

The entrance of the experiment.


Question. Why we do not display the following information in the table?

  • Created
  • First modified
  • Last modified
  • Completed
  • Last time it was selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants