Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drop target when leaving a section #2149

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Remove drop target when leaving a section #2149

merged 4 commits into from
Aug 5, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Aug 5, 2022

Part of #2115

Screen.Recording.2022-08-05.at.2.05.18.PM.mov

@sroy3 sroy3 added the bug Something isn't working label Aug 5, 2022
@sroy3 sroy3 self-assigned this Aug 5, 2022
@sroy3 sroy3 marked this pull request as ready for review August 5, 2022 20:17
})

const bottomSection = screen.getByTestId(NewSectionBlock.BOTTOM)
const aSingleViewPlot = screen.getByTestId(join('plot_other', 'plot.tsv'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[N] Could use join once.

@codeclimate
Copy link

codeclimate bot commented Aug 5, 2022

Code Climate has analyzed commit 275b3e3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 108c265 into main Aug 5, 2022
@sroy3 sroy3 deleted the dnd-clear branch August 5, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants