Move some App.test.tsx helpers to utils #2056
Conversation
wolmir
requested review from
mattseddon,
rogermparent,
sroy3 and
julieg18
as code owners
| renderTable(sortingTableDataFixture) | ||
| } | ||
|
|
||
| export const renderTableWithoutRuningExperiments = () => { |
There was a problem hiding this comment.
Did you mean renderTableWithoutRunningExperiments?
| renderTable({ ...tableDataFixture, rows: [tableDataFixture.rows[0]] }) | ||
| } | ||
|
|
||
| export const renderTableWithSortingdata = () => { |
There was a problem hiding this comment.
Did you mean renderTableWithSortingData?
| getCountIndicators, | ||
| renderTable, | ||
| renderTableWithNoColumns, | ||
| renderTableWithoutRuningExperiments, |
| renderTableWithNoColumns, | ||
| renderTableWithoutRuningExperiments, | ||
| renderTableWithPlaceholder, | ||
| renderTableWithSortingdata, |
| const tailRow = within(getRow('42b8736')).getByRole('checkbox') | ||
| fireEvent.click(tailRow, { shiftKey: true }) | ||
| clickRowCheckbox('4fb124a') | ||
| clickRowCheckbox('42b8736', true) | ||
|
|
||
| const selectedRows = screen.getAllByRole('row', { selected: true }) |
There was a problem hiding this comment.
[C] This could be a helper as well:
const selectedRows = (screen) => screen.getAllByRole('row', { selected: true })
There was a problem hiding this comment.
or import screen into the utils file.
| @@ -0,0 +1,87 @@ | |||
| /* eslint-disable unicorn/filename-case */ | |||
There was a problem hiding this comment.
In theory, it should already be in the ignore pattern of the rule (all files in test folders are ignored for PascalCase rule, but I think we had that because we used to have something like util.tsx. I'm torn between fixing the rule so that your file gets ignored and you can remove that line and just using PascalCase here (and even removing the ignore pattern on the test files).
There was a problem hiding this comment.
I forgot about this issue!
I prefer to ignore the rule for cases like this (not just tests).
My reason is that a PascalCase implies that the file is either a component (Like IconMenu.tsx) or a family of related components (like Row(s).tsx).
But for buildDynamicColumns.tsx and this file the jsx code is just ancillary stuff.
They are not the main purpose of the file.
There was a problem hiding this comment.
Then it should be in the ignore pattern of the rule. It is already the case, but it must be broken.
There was a problem hiding this comment.
I'll add it, thanks!
wolmir
force-pushed
the
try-to-shrink-app-test
branch
from
6af4cda to
e698bc9
Compare
|
Code Climate has analyzed commit 167cb08 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Based on https://github.com/iterative/vscode-dvc/pull/2004/files#r921740235