Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky test from unit test suite #2014

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Remove flaky test from unit test suite #2014

merged 2 commits into from
Jul 12, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 12, 2022

I have seen this test fail a few times in our CI. It can be removed for several reasons.

  1. We don't touch this code often (ever).
  2. The code that this test is testing will actually be replaced when we get the data:status command from DVC.
  3. The test was doing way too much for a unit test (it touches the file system for a start).

@mattseddon mattseddon self-assigned this Jul 12, 2022
@mattseddon mattseddon marked this pull request as ready for review July 12, 2022 05:32
@mattseddon mattseddon enabled auto-merge (squash) July 12, 2022 20:20
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2022

Code Climate has analyzed commit e1b73a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 0ef0ac0 into main Jul 12, 2022
@mattseddon mattseddon deleted the remove-flaky-test branch July 12, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants