Small table cell tooltip changes #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
force-pushed
the
small-tooltip-issues
branch
from
14e37fb to
a14fc65
Compare
rogermparent
commented
Jul 2, 2022
rogermparent
commented
Jul 2, 2022
| @@ -17,7 +17,7 @@ $font: var(--vscode-font-family); | |||
| white-space: nowrap; | |||
| & > :global(.tippy-arrow) { | |||
| color: $background; | |||
| z-index: 2; | |||
| z-index: 1; | |||
There was a problem hiding this comment.
Fixes a small issue with the arrow appearing over text highlighting in content
|
@rogermparent is it still a draft? |
wolmir
approved these changes
Jul 3, 2022
|
I wanted to write some real tests for the other tooltip data types, but I could do that as an immediate follow-up as well to get this fix in since it's at better tested and working than what we currently have. |
|
Code Climate has analyzed commit 0ad0819 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 33.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
wolmir
approved these changes
Jul 5, 2022
|
Please do follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1954
tooltip-data-types-demo.mp4
interactiveset on them, so users can do actions like copying text. Currently has a bug where clicking the tooltip in any way registers as a row click for selection.String, confirmed booleans, arrays, and 0 work.note: seems like
null, even when put into yaml, breaks table parsing.