Improve reset the workspace SCM command

[mattseddon]

1/2 main <- this <- #1916

The second attempt at #1900 which was reverted in #1910 (reasons for the revert are inline).

I will write up the incident.

[mattseddon]

[F] This function is only for testing. When I rewrite this I will get rid of the need for it.

[mattseddon]

[F] Bug two.

Was a great example of trying to do something clever that turned out to be incredibly dumb.

Previous code:

export type DecorationState = Record<Status, Set<string>>

export interface DecorationModel {
  getState: () => DecorationState
}

enum Status {
  ADDED = 'added',
  DELETED = 'deleted',
  MODIFIED = 'modified',
  NOT_IN_CACHE = 'notInCache',
  RENAMED = 'renamed',
  GIT_MODIFIED = 'gitModified',
  TRACKED = 'tracked'
}

export class DecorationProvider
  extends Disposable
  implements FileDecorationProvider
{
...

  public setState(state: DecorationState) {
    const urisToUpdate = this.getUnion(this.state, state)
    this.state = state
    this.decorationsChanged.fire(urisToUpdate)
  }

  private getUnion(existingState: DecorationState, newState: DecorationState) {
    return flattenUnique([
      ...Object.values(existingState).map(status => [...(status || [])]),
      ...Object.values(newState).map(status => [...(status || [])])
    ]).map(path => Uri.file(path))
  }

export class RepositoryModel
  extends Disposable
  implements DecorationModel, SourceControlManagementModel
{
...
  public getState() {
    const acc = []
    for (const relTrackedOut of this.relTrackedOuts) {
      acc.push(join(this.dvcRoot, relTrackedOut))
    }

    return {
      ...omit(this.state, ['trackedLeafs', 'trackedNonLeafs']),
      hasRemote: new Set([...acc, ...this.state.trackedLeafs]),
      tracked: this.getTracked()
    }
  }

The way that this was setup meant that the compiler couldn't/didn't warn me that I was putting a boolean into Uri.file which causes a silently rejected promise and stopped any decorations from being provided.

I've changed the code to be very explicit in terms of what the DecorationProvider and SourceContorlManagement expect for state.

[mattseddon]

[F] The first bug was here. git status touches .git/index which fired the watcher which ran git status which...

[mattseddon]

I'm going to follow up and remove this. It is only used for testing purposes. This change is big enough now though.

[codeclimate]

Code Climate has analyzed commit 9ae60af and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.