Add storybook design addon #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroy3
approved these changes
Jun 3, 2022
|
Code Climate has analyzed commit 3d21cb7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
storybook-addon-designsto our Storybook setup, allowing us to associate specific Figma files to specific stories and view those figmas inside the Storybook UI. This works on both the individual story level and the module (file) level via theparametersfield.There is also a separate figma plugin to do integration in the opposite direction, i.e. viewing Storybook stories in Figma.
storybook-figma-demo.mp4
This use case may drive us to reconsider the format we keep our Figma files, seemingly being more oriented to files that just exhibit a UI element without much explanatory chrome surrounding that but it's also not impossible to use as-is so I'll leave it up to a discussion of our preferences on the dev and design side.