Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README rewrite (+ CONTRIB updates) #1816
README rewrite (+ CONTRIB updates) #1816
Changes from all commits
9a3b54e
9258493
7a089a1
9d21977
249d88e
35aa202
6dc30f6
2f9ccd1
9da66a8
d9b7130
7635990
aabb42f
af21897
ed3ccd3
abbb7c0
96e3365
a035ea5
632d8e6
447245c
92a37b1
7ce9fdf
e4cde08
6ee4d02
49b7991
9e6218a
392c60e
14e80ec
69fe8ad
3aaea33
3aca21d
2fdf8f5
820983e
2375289
9804ca6
1f3165d
736a01b
0b6a2e8
f7363fb
b486ac6
de63e81
c15964d
ed3f4ff
45876a6
935b36b
4ca6219
b3d63ff
52acd1d
b3c21a1
3e96de3
adb1330
91f37db
2f3d458
f55dba4
91138fb
0cd8a3d
005e5fc
f227d87
1aaee80
fb9619a
864a362
16d6dda
e8c681e
d099f31
75e883f
4aadbd3
38bb119
b0fa7ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another question is whether this file affects the VS Code extension itself. May be confusing to include it in the repo if not...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only developer experience for developing the extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make external links open in a new tab by default? This is auto-applied in the VS Code Marketplace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not anyone ... this tool is personal mostly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we are mainly listing DVC value/ features, right? Exp mgmt, plots, DVCLive, reproducibility, data versioning/mgmt.
Anyone could enjoy the DVC project benefits in some other environment, with or without the extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bold claim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could replace "best developer experience" with "VS Code" or link to surveys showing it's the preferred IDE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the company's mission guys! 😃 This particular README has to sell itself since it's what people see on the marketplace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to do this, but probably not in the list of the items that are different in style
you can end with this phase:
in a sense like "hey ... give it a try and enjoy .... :)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not following here @shcheklein. Items that are different in style?
This pretty much comes straight from the official value prop, as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a ToC? Unlike in GH, https://marketplace.visualstudio.com/items?itemName=Iterative.dvc doesn't auto-generate one nor does it add 🔗 anchors per header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change resources/walkthrough links for proper docs? Rel. iterative/dvc.org#3663
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be helpful to mention https://github.com/iterative/vscode-dvc/issues again here and try to describe which issues should go where. Or should we just give one channel for issues and leave it to our internal teams to move issues as needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using Discord first and then link to GH issues in both places now. I think people will mostly know what each channel is for, probably preferring the chat in most cases, esp. for beginner questions.