Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plots ribbon to show and remove experiments #1785

Merged
merged 11 commits into from
May 31, 2022
Merged

Add plots ribbon to show and remove experiments #1785

merged 11 commits into from
May 31, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented May 27, 2022

Screen.Recording.2022-05-27.at.2.38.08.PM.mov

@sroy3 sroy3 added the product PR that affects product label May 27, 2022
@sroy3 sroy3 self-assigned this May 27, 2022
@sroy3 sroy3 marked this pull request as ready for review May 30, 2022 12:30
@sroy3
Copy link
Contributor Author

sroy3 commented May 30, 2022

Fixing the console error Warning: An update to RibbonBlock inside a test was not wrapped in act(...). It'll be in my other PR coming later today or tomorrow.

Copy link
Member

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things to follow up on.


const copyExp = async (exp: string) => {
try {
await navigator.clipboard.writeText(exp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Do we want to add the copy icon on hover as we do in the experiments table?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to see if it fits. If it does, I'll open another PR for it.

@codeclimate
Copy link

codeclimate bot commented May 31, 2022

Code Climate has analyzed commit 6ded069 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.2% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit c8c3a22 into main May 31, 2022
@sroy3 sroy3 deleted the plots-ribbon branch May 31, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants