Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make size of comparison table column more consistent #1744

Merged
merged 4 commits into from
May 19, 2022
Merged

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented May 19, 2022

Screen.Recording.2022-05-19.at.2.46.06.PM.mov

@sroy3 sroy3 added the product PR that affects product label May 19, 2022
@sroy3 sroy3 self-assigned this May 19, 2022
@sroy3 sroy3 changed the title Comparison table size Make size of comparison table column more consistent May 19, 2022
@sroy3 sroy3 marked this pull request as ready for review May 19, 2022 18:46
@mattseddon
Copy link
Member

mattseddon commented May 19, 2022

[Q] What does a single image by itself (one experiment selected) look like now?

@sroy3
Copy link
Contributor Author

sroy3 commented May 19, 2022

[Q] What does a single image by itself (one experiment selected) look like now?

Screen Shot 2022-05-19 at 5 37 43 PM

The width is always the same, no matter how many columns there are.

@sroy3 sroy3 enabled auto-merge (squash) May 19, 2022 22:26
@codeclimate
Copy link

codeclimate bot commented May 19, 2022

Code Climate has analyzed commit 117d634 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 024aa30 into main May 19, 2022
@sroy3 sroy3 deleted the comparison-table-size branch May 19, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants