Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create release pr workflow #1685

Merged
merged 18 commits into from
May 13, 2022
Merged

Add create release pr workflow #1685

merged 18 commits into from
May 13, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 10, 2022 •
edited
Loading

Relates to #1691.

This PR adds a new workflow that will create a release PR which updates the changelog and extension version.

The release process will work as follows:

  1. Manually trigger create-release-pr against main.
  2. A PR will be generated to update the version and changelog. Changelog update will reflect the PRs merged since the last version was released and will be grouped as per this - groups to be discussed.
  3. PR should be closed/reopened (trigger workflows to run for merge checks).
  4. Review, approve, merge the PR.
  5. Run the publish workflow. This will release to the marketplace, tags the commit and creates a GH release.

Demo

#1692

TODO:

@mattseddon mattseddon self-assigned this May 10, 2022
@mattseddon mattseddon force-pushed the add-create-release-action branch 2 times, most recently from a6fdea6 to 2b6ecba Compare May 10, 2022 05:08
@mattseddon mattseddon changed the base branch from main to upgrade-checkout-action May 10, 2022 05:23
@mattseddon mattseddon force-pushed the upgrade-checkout-action branch from 8b11ff2 to 0bcc959 Compare May 10, 2022 20:26
@mattseddon mattseddon force-pushed the add-create-release-action branch from 8a71b88 to 85e3849 Compare May 10, 2022 20:28
Base automatically changed from upgrade-checkout-action to main May 10, 2022 20:28
@mattseddon mattseddon force-pushed the add-create-release-action branch from 85e3849 to 6ccbd8a Compare May 10, 2022 21:58
@mattseddon mattseddon force-pushed the add-create-release-action branch from d1c4c9b to b18de09 Compare May 11, 2022 02:12
@mattseddon mattseddon force-pushed the add-create-release-action branch from b18de09 to 9f92426 Compare May 11, 2022 02:15
mattseddon
mattseddon commented May 11, 2022
View reviewed changes
.github/workflows/changelog-config.json
@@ -0,0 +1,18 @@
{
"categories": [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD in retro

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMK what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include maintenance/housekeeping in there? Is this important for the user to know we did "Migrate from toEqual to toStrictEqual" for example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes yes, sometimes no. Maybe we can add a maintenance label. I didn't think to hard about it when I copied how DVC does it. Looks like they publish everything.

@mattseddon mattseddon requested a review from a team May 11, 2022 02:41
@mattseddon mattseddon marked this pull request as ready for review May 11, 2022 02:42
sroy3
sroy3 approved these changes May 11, 2022
View reviewed changes
.github/workflows/changelog-config.json
@@ -0,0 +1,18 @@
{
"categories": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include maintenance/housekeeping in there? Is this important for the user to know we did "Migrate from toEqual to toStrictEqual" for example?

rogermparent
rogermparent approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can figure out something a little more elegant, but this definitely works for now.

@mattseddon mattseddon force-pushed the add-create-release-action branch 11 times, most recently from cf56beb to ecb0188 Compare May 13, 2022 01:14
@mattseddon mattseddon force-pushed the add-create-release-action branch from ecb0188 to 890e30c Compare May 13, 2022 01:19
@codeclimate
Copy link

codeclimate bot commented May 13, 2022

Code Climate has analyzed commit c157429 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon enabled auto-merge (squash) May 13, 2022 01:22
@mattseddon mattseddon merged commit 2587b61 into main May 13, 2022
@mattseddon mattseddon deleted the add-create-release-action branch May 13, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogermparent rogermparent rogermparent approved these changes

@sroy3 sroy3 sroy3 approved these changes

Assignees

@mattseddon mattseddon

Labels
🏠 housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattseddon @sroy3 @rogermparent