Queue experiment from existing #1159
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import { Flag } from '../../../cli/args' | ||
| import { definedAndNonEmpty } from '../../../util/array' | ||
|
|
||
| export const pickParamsAndVary = async (params: Param[]) => { |
There was a problem hiding this comment.
Function pickParamsAndVary has 30 lines of code (exceeds 25 allowed). Consider refactoring.
| public getExperimentNames() { | ||
| return [ | ||
| 'workspace', | ||
| ...this.flattenExperiments().map(experiment => experiment.displayName) | ||
| ].filter(Boolean) as string[] | ||
| } |
There was a problem hiding this comment.
Should we consolidate this and pickExperimentName from extension/src/experiments/workspace.ts? As far as I can tell, they do the same thing but this is more efficient since it uses our internal model over running exp list.
There was a problem hiding this comment.
This includes queued experiments. The other does not. I will take a look though.
There was a problem hiding this comment.
@rogermparent we use AvailableCommands.EXPERIMENT_LIST_CURRENT for applying and branching experiments. We can switch to using code that pulls the names out of the model. I will follow up.
|
Code Climate has analyzed commit bdae358 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 92.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.1% (-0.1% change). View more on Code Climate. |
This PR begins to address the first part of #1135 by adding a multi-step quick pick/input box process to queue a new experiment from an existing one's params. We will be able to wire this up to the webview in the future and execute the command by selecting a row.
The steps are:
Demo
Screen.Recording.2021-12-15.at.4.49.03.pm.mov
Note: Queueing experiments using
-Scauses weird things to happen when we try to run them. This is a known issue: iterative/dvc#5971