Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of when the extension is running an experiment #262

Closed
rogermparent opened this issue Apr 13, 2021 · 2 comments
Closed

Keep track of when the extension is running an experiment #262

rogermparent opened this issue Apr 13, 2021 · 2 comments
Labels
A: experiments Area: experiments table webview and everything related A: extension Area: core extension priority-p1 Regular product backlog

Comments

@rogermparent
Copy link
Contributor

rogermparent commented Apr 13, 2021

Related to #230 and #231, and loosely to #261

In order to add UI elements that conditionally change when there is a currently running experiment that we can stop, we'll need to add the ability to track when an experiment is currently running.

This can be deceptively complicated, as with the IntegratedTerminal we currently cannot directly know when a command is done executing. We'll need to solve this with something like a Task+Pseudoterminal before solving this, so much so that an improved way to run terminals with activated environments is 99% the solution to this Issue, with the rest being a public boolean field.

There's also the consideration of keeping track of when external experiments are running, and while that could be a useful thing to know, there isn't a much we can do with that information that isn't already taken care of by knowing when the repo is locked unless we can find the pid of the running experiment, which I don't believe we can with dvc's current behavior.

@mattseddon
Copy link
Member

Related to #267.

@shcheklein shcheklein added A: experiments Area: experiments table webview and everything related A: extension Area: core extension priority-p1 Regular product backlog labels Apr 20, 2021
@shcheklein shcheklein changed the title Keep Track of when the Extension is running an Experiment Keep track of when the extension is running an experiment Apr 27, 2021
@mattseddon
Copy link
Member

@rogermparent I think we've handled this successfully now, feel free to re-open if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related A: extension Area: core extension priority-p1 Regular product backlog
Projects
None yet
Development

No branches or pull requests

3 participants