Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of when DVC repo is locked #261

Closed
rogermparent opened this issue Apr 13, 2021 · 6 comments
Closed

Keep track of when DVC repo is locked #261

rogermparent opened this issue Apr 13, 2021 · 6 comments
Labels
🎨 design Needs design input or is being actively worked on research

Comments

@rogermparent
Copy link
Contributor

Related to #230 and #231

In order to implement user-friendly UI elements that are disabled when we know that they'll fail, we'll need to keep track of when the DVC repo is locked.

I would think this is as easy as adding a vscode file watcher for the dvc lockfile.

@mattseddon
Copy link
Member

mattseddon commented Apr 13, 2021

Is there a related DVC issue for this?

I.e are they investigating not locking the repo for readonly options?

@shcheklein
Copy link
Member

I.e are they investigating not locking the repo for readonly options?

good question. Probably not exactly related to this specific issue though? We will still need a mechanism to detect and disable certain actions (and show the message). Or allow and fail gracefully. Any of those approaches is fine to me. WDYT?

cc @yalozhkin

@shcheklein shcheklein added the 🎨 design Needs design input or is being actively worked on label Apr 20, 2021
@shcheklein
Copy link
Member

Aslo, how does Git extension behave when repo is locked?

@shcheklein shcheklein added research A: extension Area: core extension labels Apr 20, 2021
@rogermparent
Copy link
Contributor Author

rogermparent commented Apr 20, 2021

We will still need a mechanism to detect and disable certain actions (and show the message). Or allow and fail gracefully. Any of those approaches is fine to me. WDYT?

I think there's no getting around needing to gracefully handle when DVC is called while locked. We'll probably even want to handle different commands in different ways: roughly, light read-only commands like exp show could silently attempt a retry while commands that mutate the repo or just take a while like exp apply or exp run would provide an error message with feedback.

I believe we could also use showErrorMessage's generic items API to add clickable options for rich handling of these errors (like a "retry" option on lock errors)

@shcheklein shcheklein changed the title Keep Track of when DVC Repo is Locked Keep track of when DVC repo is locked Apr 27, 2021
@mattseddon mattseddon removed the A: extension Area: core extension label Aug 16, 2021
@mattseddon
Copy link
Member

@rogermparent I think we can track this under #643, WDYT?

@mattseddon
Copy link
Member

Duplicate of #643 and better covered by #772, closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Needs design input or is being actively worked on research
Projects
None yet
Development

No branches or pull requests

3 participants