Add more tests

iterative · Oct 3, 2022 · d962189 · d962189
1 parent 3f9ded2
commit d962189
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 20 deletions.
diff --git a/languageServer/src/documentSelector.ts b/languageServer/src/documentSelector.ts
diff --git a/languageServer/src/test/definitions.test.ts b/languageServer/src/test/definitions.test.ts
@@ -104,20 +104,23 @@ describe('textDocument/definitions', () => {
         languageId: 'json',
         mockContents: '',
         mockPath: 'moreParams/otherParams.json'
+      },
+      {
+        languageId: 'blankLang',
+        mockContents: '',
+        mockPath: 'data/blankFile'
       }
     ])
 
     let response = await requestDefinitions(dvcYaml, 'params.json')
 
-    expect(response).toBeTruthy()
     expect(response).toStrictEqual({
       range: Range.create(Position.create(0, 0), Position.create(0, 0)),
       uri: 'file:///params.json'
     })
 
     response = await requestDefinitions(dvcYaml, 'otherParams.json')
 
-    expect(response).toBeTruthy()
     expect(response).toStrictEqual({
       range: Range.create(Position.create(0, 0), Position.create(0, 0)),
       uri: 'file:///moreParams/otherParams.json'

diff --git a/languageServer/src/test/fixtures/examples/valid/index.ts b/languageServer/src/test/fixtures/examples/valid/index.ts
@@ -77,6 +77,7 @@ stages:
     params:
       - params.json
       - moreParams/otherParams.json
+      - data/blankFile
   stage2:
     cmd:
       - echo hello

diff --git a/languageServer/src/test/utils/openTheseFilesAndNotifyServer.ts b/languageServer/src/test/utils/openTheseFilesAndNotifyServer.ts
@@ -13,7 +13,7 @@ export const openTheseFilesAndNotifyServer = async (
     const textDocument = TextDocument.create(uri, languageId, 1, mockContents)
     await client.sendNotification(DidOpenTextDocumentNotification.type, {
       textDocument: {
-        languageId: 'yaml',
+        languageId,
         text: textDocument.getText(),
         uri: textDocument.uri,
         version: textDocument.version