self review

iterative · Mar 14, 2023 · c1591c6 · c1591c6
1 parent fadacfb
commit c1591c6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 19 deletions.
diff --git a/extension/package.json b/extension/package.json
@@ -399,11 +399,6 @@
         "command": "dvc.showCommands",
         "category": "DVC"
       },
-      {
-        "title": "Open Studio Settings",
-        "command": "dvc.showStudioSettings",
-        "category": "DVC"
-      },
       {
         "title": "Show Experiments",
         "command": "dvc.showExperiments",
@@ -814,10 +809,6 @@
           "command": "dvc.stopQueuedExperiments",
           "when": "dvc.commands.available && dvc.project.available"
         },
-        {
-          "command": "dvc.showStudioSettings",
-          "when": "dvc.commands.available && dvc.project.available && dvc.studio.connected"
-        },
         {
           "command": "dvc.selectForCompare",
           "when": "false"

diff --git a/extension/src/setup/register.ts b/extension/src/setup/register.ts
@@ -66,6 +66,6 @@ export const registerSetupCommands = (
     }
   )
 
-  registerSetupStudioCommands(setup, internalCommands)
   registerSetupConfigCommands(setup, internalCommands)
+  registerSetupStudioCommands(setup, internalCommands)
 }
diff --git a/webview/src/setup/components/App.tsx b/webview/src/setup/components/App.tsx
@@ -10,7 +10,7 @@ import {
 import React, { useCallback, useState } from 'react'
 import { Experiments } from './Experiments'
 import { Studio } from './Studio'
-import { SectionContainer } from './SectionContainer'
+import { SetupContainer } from './SetupContainer'
 import { useVsCodeMessaging } from '../../shared/hooks/useVsCodeMessaging'
 import { sendMessage } from '../../shared/vscode'
 
@@ -79,7 +79,7 @@ export const App: React.FC = () => {
 
   return (
     <>
-      <SectionContainer
+      <SetupContainer
         sectionKey={Section.EXPERIMENTS}
         title={'Experiments'}
         sectionCollapsed={sectionCollapsed}
@@ -95,8 +95,8 @@ export const App: React.FC = () => {
           projectInitialized={projectInitialized}
           pythonBinPath={pythonBinPath}
         />
-      </SectionContainer>
-      <SectionContainer
+      </SetupContainer>
+      <SetupContainer
         sectionKey={Section.STUDIO}
         title={'Studio'}
         sectionCollapsed={sectionCollapsed}
@@ -107,7 +107,7 @@ export const App: React.FC = () => {
           shareLiveToStudio={shareLiveToStudio}
           setShareLiveToStudio={setShareLiveToStudio}
         />
-      </SectionContainer>
+      </SetupContainer>
     </>
   )
 }
diff --git a/...src/setup/components/SectionContainer.tsx → ...w/src/setup/components/SetupContainer.tsx b/...src/setup/components/SectionContainer.tsx → ...w/src/setup/components/SetupContainer.tsx
@@ -3,9 +3,9 @@ import {
   Section
 } from 'dvc/src/setup/webview/contract'
 import React from 'react'
-import { SectionContainer as SharedSectionContainer } from '../../shared/components/sectionContainer/SectionContainer'
+import { SectionContainer } from '../../shared/components/sectionContainer/SectionContainer'
 
-export const SectionContainer: React.FC<{
+export const SetupContainer: React.FC<{
   children: React.ReactNode
   sectionCollapsed: typeof DEFAULT_SECTION_COLLAPSED
   sectionKey: Section
@@ -18,7 +18,7 @@ export const SectionContainer: React.FC<{
   setSectionCollapsed,
   title
 }) => (
-  <SharedSectionContainer
+  <SectionContainer
     sectionCollapsed={sectionCollapsed[sectionKey]}
     sectionKey={sectionKey}
     title={title}
@@ -30,5 +30,5 @@ export const SectionContainer: React.FC<{
     }
   >
     {children}
-  </SharedSectionContainer>
+  </SectionContainer>
 )