add editor light bulb for selected star

iterative · Oct 17, 2022 · be78446 · be78446
1 parent 3362e11
commit be78446
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 20 deletions.
diff --git a/webview/src/experiments/components/table/styles.module.scss b/webview/src/experiments/components/table/styles.module.scss
@@ -505,18 +505,6 @@ $bullet-size: calc(var(--design-unit) * 4px);
           margin-right: 2px;
         }
 
-        .starSwitch {
-          display: inline-flex;
-          align-items: center;
-          justify-content: center;
-          width: 14px;
-          cursor: pointer;
-
-          &[aria-checked='true'] {
-            opacity: 1;
-          }
-        }
-
         .indicatorIcon {
           display: inline-flex;
           align-items: center;
@@ -559,15 +547,27 @@ $bullet-size: calc(var(--design-unit) * 4px);
   }
 }
 
-.experimentCell .rowActions .starSwitch svg {
-  fill: $icon-color;
+.starSwitch {
+  display: inline-flex;
+  align-items: center;
+  justify-content: center;
+  width: 14px;
+  cursor: pointer;
+
+  svg {
+    fill: $icon-color;
 
-  .rowSelected & {
-    fill: $selected-icon-color;
+    .rowSelected & {
+      fill: $selected-icon-color;
+    }
+  }
+
+  &[aria-checked='true'] svg {
+    fill: $row-action-star-checked;
   }
 }
 
-.cellHintTooltip {
+.starSwitch .cellHintTooltip {
   font-size: 0.65rem;
 }
 
@@ -763,9 +763,6 @@ $badge-size: 0.85rem;
   height: 1.5rem;
   cursor: pointer;
   svg {
-    fill: $watermark-color;
-  }
-  &.indicatorWithCount svg {
     fill: $icon-color;
   }
 }

diff --git a/webview/src/shared/variables.scss b/webview/src/shared/variables.scss
@@ -35,6 +35,7 @@ $selected-icon-color: var(
   --vscode-list-activeSelectionIconForeground,
   var(--vscode-descriptionForeground)
 );
+$row-action-star-checked: var(--vscode-editorLightBulb-foreground);
 
 $shadow: var(--vscode-widget-shadow);