self review

iterative · Apr 28, 2023 · b756673 · b756673
1 parent 627c5fe
commit b756673
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 43 deletions.
diff --git a/extension/package.json b/extension/package.json
@@ -564,6 +564,11 @@
           "type": "boolean",
           "default": null
         },
+        "dvc.doNotRecommendAddStudioToken": {
+          "description": "Do not prompt to add a studio.token to the global DVC config, which enables automatic sharing of experiments to Studio.",
+          "type": "boolean",
+          "default": null
+        },
         "dvc.doNotShowCliUnavailable": {
           "description": "Do not warn when the workspace contains a DVC project but the DVC binary is unavailable.",
           "type": "boolean",

diff --git a/extension/src/commands/external.ts b/extension/src/commands/external.ts
@@ -14,7 +14,7 @@ export enum RegisteredCliCommands {
 
   EXPERIMENT_VIEW_APPLY = 'dvc.views.experiments.applyExperiment',
   EXPERIMENT_VIEW_BRANCH = 'dvc.views.experiments.branchExperiment',
-  EXPERIMENT_VIEW_PUSH = 'dvc.views.experiments.pushExperiment',
+  EXPERIMENT_VIEW_SHARE = 'dvc.views.experiments.shareExperiment',
   EXPERIMENT_VIEW_REMOVE = 'dvc.views.experiments.removeExperiment',
   EXPERIMENT_VIEW_SHOW_LOGS = 'dvc.views.experiments.showLogs',
   EXPERIMENT_VIEW_STOP = 'dvc.views.experiments.stopQueueExperiment',
@@ -100,7 +100,6 @@ export enum RegisteredCommands {
   ADD_STUDIO_ACCESS_TOKEN = 'dvc.addStudioAccessToken',
   UPDATE_STUDIO_ACCESS_TOKEN = 'dvc.updateStudioAccessToken',
   REMOVE_STUDIO_ACCESS_TOKEN = 'dvc.removeStudioAccessToken',
-  EXPERIMENT_VIEW_SHARE_TO_STUDIO = 'dvc.views.experiments.shareExperimentToStudio',
   SETUP_SHOW_STUDIO_CONNECT = 'dvc.showStudioConnect',
   SETUP_SHOW_STUDIO_SETTINGS = 'dvc.showStudioSettings',
 

diff --git a/extension/src/experiments/commands/index.test.ts b/extension/src/experiments/commands/index.test.ts
diff --git a/extension/src/experiments/commands/register.ts b/extension/src/experiments/commands/register.ts
@@ -292,8 +292,8 @@ export const registerExperimentCommands = (
       experiments.getRepository(dvcRoot).toggleExperimentStatus(id)
   )
 
-  internalCommands.registerExternalCommand(
-    RegisteredCommands.EXPERIMENT_VIEW_SHARE_TO_STUDIO,
+  internalCommands.registerExternalCliCommand(
+    RegisteredCliCommands.EXPERIMENT_VIEW_SHARE,
     getShareExperimentToStudioCommand(internalCommands, setup)
   )
 

diff --git a/extension/src/experiments/webview/messages.ts b/extension/src/experiments/webview/messages.ts
@@ -196,7 +196,7 @@ export class WebviewMessages {
       }
       case MessageFromWebviewType.SHARE_EXPERIMENT:
         return commands.executeCommand(
-          RegisteredCommands.EXPERIMENT_VIEW_SHARE_TO_STUDIO,
+          RegisteredCliCommands.EXPERIMENT_VIEW_SHARE,
           { dvcRoot: this.dvcRoot, id: message.payload }
         )
 

diff --git a/extension/src/telemetry/constants.ts b/extension/src/telemetry/constants.ts
@@ -142,9 +142,8 @@ export interface IEventNamePropertyMapping {
   [EventName.EXPERIMENT_TOGGLE]: undefined
   [EventName.EXPERIMENT_VIEW_APPLY]: undefined
   [EventName.EXPERIMENT_VIEW_BRANCH]: undefined
-  [EventName.EXPERIMENT_VIEW_PUSH]: undefined
   [EventName.EXPERIMENT_VIEW_REMOVE]: undefined
-  [EventName.EXPERIMENT_VIEW_SHARE_TO_STUDIO]: undefined
+  [EventName.EXPERIMENT_VIEW_SHARE]: undefined
   [EventName.EXPERIMENT_VIEW_SHOW_LOGS]: undefined
   [EventName.EXPERIMENT_VIEW_STOP]: undefined
   [EventName.QUEUE_EXPERIMENT]: undefined