Skip to content

Commit

Permalink
Switch executeDvcProcess method to protected
Browse files Browse the repository at this point in the history
  • Loading branch information
mattseddon committed Apr 27, 2023
1 parent 626328a commit 5d20e4c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions extension/src/cli/dvc/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ describe('executeDvcProcess', () => {
}
)

await cli.executeDvcProcess(cwd, ...args)
// eslint-disable-next-line @typescript-eslint/no-explicit-any
await (cli as any).executeDvcProcess(cwd, ...args)

expect(mockedCreateProcess).toHaveBeenCalledWith({
args,
Expand Down Expand Up @@ -119,7 +120,8 @@ describe('executeDvcProcess', () => {
}
)

await expect(cli.executeDvcProcess(cwd, ...args)).rejects.toThrow()
// eslint-disable-next-line @typescript-eslint/no-explicit-any
await expect((cli as any).executeDvcProcess(cwd, ...args)).rejects.toThrow()

expect(mockedCreateProcess).toHaveBeenCalledWith({
args,
Expand Down
2 changes: 1 addition & 1 deletion extension/src/cli/dvc/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class DvcCli extends Cli {
this.config = config
}

public executeDvcProcess(cwd: string, ...args: Args): Promise<string> {
protected executeDvcProcess(cwd: string, ...args: Args): Promise<string> {
const options = this.getOptions(cwd, ...args)
return this.executeProcess(options)
}
Expand Down

0 comments on commit 5d20e4c

Please sign in to comment.