Add "(pip)" to setup install button (#4013)

iterative · May 31, 2023 · 4ab0a46 · 4ab0a46
1 parent acfd8f9
commit 4ab0a46
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/webview/src/setup/components/App.test.tsx b/webview/src/setup/components/App.test.tsx
@@ -165,7 +165,7 @@ describe('App', () => {
           `DVC & DVCLive can be auto-installed as packages with ${defaultInterpreter}`
         )
       ).toBeInTheDocument()
-      expect(screen.getByText('Install')).toBeInTheDocument()
+      expect(screen.getByText('Install (pip)')).toBeInTheDocument()
     })
 
     it('should let the user find another Python interpreter to install DVC when the Python extension is not installed', () => {
@@ -215,7 +215,7 @@ describe('App', () => {
         pythonBinPath: 'python'
       })
 
-      const button = screen.getByText('Install')
+      const button = screen.getByText('Install (pip)')
       fireEvent.click(button)
 
       expect(mockPostMessage).toHaveBeenCalledWith({

diff --git a/webview/src/setup/components/dvc/CliUnavailable.tsx b/webview/src/setup/components/dvc/CliUnavailable.tsx
@@ -18,7 +18,7 @@ export const CliUnavailable: React.FC<PropsWithChildren> = ({ children }) => {
         DVC & DVCLive can be auto-installed as packages with {pythonBinPath}
       </p>
       <div className={styles.sideBySideButtons}>
-        <Button onClick={installDvc} text="Install" />
+        <Button onClick={installDvc} text="Install (pip)" />
         <Button onClick={setupWorkspace} text="Configure" />
       </div>
     </>

diff --git a/webview/src/stories/Setup.stories.tsx b/webview/src/stories/Setup.stories.tsx
@@ -98,8 +98,8 @@ CompletedConnected.args = getUpdatedArgs({
   shareLiveToStudio: true
 })
 
-export const NoCLIPythonNotFound = Template.bind({})
-NoCLIPythonNotFound.args = getUpdatedArgs({
+export const CLIPythonNotFound = Template.bind({})
+CLIPythonNotFound.args = getUpdatedArgs({
   cliCompatible: undefined,
   dvcCliDetails: {
     command: 'dvc',
@@ -109,8 +109,8 @@ NoCLIPythonNotFound.args = getUpdatedArgs({
   pythonBinPath: undefined
 })
 
-export const NoCLIPythonFound = Template.bind({})
-NoCLIPythonFound.args = getUpdatedArgs({
+export const CLIPythonFound = Template.bind({})
+CLIPythonFound.args = getUpdatedArgs({
   cliCompatible: undefined,
   dvcCliDetails: {
     command: '/opt/homebrew/Caskroom/miniforge/base/bin/python -m dvc',