Suppress ctx menu sorting options for unsortable headers (#2583)

iterative · Oct 13, 2022 · 298ef70 · 298ef70
1 parent 8ff8585
commit 298ef70
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/webview/src/experiments/components/App.test.tsx b/webview/src/experiments/components/App.test.tsx
@@ -702,9 +702,7 @@ describe('App', () => {
       const itemLabels = menuitems.map(item => item.textContent)
       expect(itemLabels).toStrictEqual([
         'Open to the Side',
-        'Set Max Header Height',
-        'Sort Ascending',
-        'Sort Descending'
+        'Set Max Header Height'
       ])
     })
 
@@ -717,7 +715,7 @@ describe('App', () => {
       jest.advanceTimersByTime(100)
 
       const menuitems = screen.getAllByRole('menuitem')
-      expect(menuitems).toHaveLength(4)
+      expect(menuitems).toHaveLength(2)
 
       fireEvent.keyDown(paramsFileHeader, { bubbles: true, key: 'Escape' })
       expect(screen.queryAllByRole('menuitem')).toHaveLength(0)

diff --git a/webview/src/experiments/components/table/TableHeader.tsx b/webview/src/experiments/components/table/TableHeader.tsx
@@ -108,7 +108,7 @@ export const TableHeader: React.FC<TableHeaderProps> = ({
       menuContent={
         <div>
           <MessagesMenu options={contextMenuOptions} />
-          {
+          {isSortable && (
             <>
               <VSCodeDivider />
               <MessagesMenu
@@ -149,7 +149,7 @@ export const TableHeader: React.FC<TableHeaderProps> = ({
                 ]}
               />
             </>
-          }
+          )}
         </div>
       }
     />