Require DVC >2.45.1 #481
Merged
Require DVC >2.45.1 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround #397 for live experiments with `dvc exp run`. Allows to send live experiment updates when running inside `dvc exp run` and DVC is not available as a Python library.
This was referenced Mar 2, 2023
daavoo
force-pushed
the
require-dvc
branch
2 times, most recently
from
c0e676f to
085736d
Compare
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
Mar 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 95.71% 96.08% +0.36%
==========================================
Files 37 38 +1
Lines 2336 2401 +65
Branches 196 199 +3
==========================================
+ Hits 2236 2307 +71
+ Misses 61 55 -6
Partials 39 39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Do we first need to drop dvclive from the dvc deps to avoid a circular dependency? |
dberenbaum
approved these changes
Mar 2, 2023
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
Mar 2, 2023
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
Mar 3, 2023
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
Mar 3, 2023
|
Should we also update the min DVC version required here? I guess it should require 2.45.2? |
Closes #473
Just updated the requirement to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unbreak to live-experiments, see https://github.com/iterative/studio/issues/5259 for context