studio: Don't skip data event if _inside_dvc_exp.

[daavoo]

Workaround #397 for live experiments with dvc exp run.

Closes #473

Allows to send data updates when running inside dvc exp run and DVC is not available as a Python library.

[codecov-commenter]

Codecov Report

Base: 95.71% // Head: 95.96% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (b0a2d44) compared to base (3308c68).
Patch coverage: 84.48% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   95.71%   95.96%   +0.24%     
==========================================
  Files          37       37              
  Lines        2336     2355      +19     
  Branches      196      196              
==========================================
+ Hits         2236     2260      +24     
+ Misses         61       57       -4     
+ Partials       39       38       -1     

Impacted Files	Coverage Δ
src/dvclive/live.py	92.96% <72.41%> (+1.81%)	⬆️
src/dvclive/dvc.py	90.56% <87.50%> (+0.27%)	⬆️
tests/test_dvc.py	100.00% <100.00%> (ø)
tests/test_studio.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dberenbaum]

Does it work for repro (which is still much more common in CML)?

DVC is not available as a Python library

Can we better clarify in the code or tests that this is what it's for? It took me a bit to understand how self._dvc_repo was being used here, and it seems poorly named for this usage. Maybe we could have distinct methods/attributes to determine whether there is a DVC repo and whether DVC is installed as a lib?

[daavoo]

Does it work for repro (which is still much more common in CML)?

No

Maybe we could have distinct methods/attributes to determine whether there is a DVC repo and whether DVC is installed as a lib?

Yes, we should do that. Addressing it should also improve the warnings as the current warning is misleading when DVC is not available as a lib.

[daavoo]

Yes, we should do that. Addressing it should also improve the warnings as the current warning is misleading when DVC is not available as a lib.

Will just do it in this P.R.

[daavoo]

Does it work for repro (which is still much more common in CML)?

To add on this, I just feel like we should not support live experiments with dvc repro

[dberenbaum]

To add on this, I just feel like we should not support live experiments with dvc repro

Let's discuss in #474 😄

[dberenbaum]

@daavoo Is it ready for another review?

[shcheklein]

minor: name is a bit misleading ... dvc_lib_available?

[daavoo]

@daavoo Is it ready for another review?

@dberenbaum yes

[daavoo]

Unrelated but dvc_studio_client has been in install_requires of dvclive for a while

[dberenbaum]

A couple questions:

1. This looks like it prioritizes warning about installing DVC lib over having a DVC repo. Maybe it's better to always check both and provide both warnings so people don't solve one error only to run into the next?
2. It doesn't need to block this PR, but it feels like with the increasing integration with DVC, we need to come to some resolution on remove dvc lib requirement #397 and consider in what scenarios DVCLive makes sense without DVC or a DVC repo. It may be better to require these generally rather than check for them for enabling each individual feature.

[daavoo]

1. This looks like it prioritizes warning about installing DVC lib over having a DVC repo. Maybe it's better to always check both and provide both warnings so people don't solve one error only to run into the next?

Done.

2. It doesn't need to block this PR, but it feels like with the increasing integration with DVC, we need to come to some resolution on [remove dvc lib requirement #397](https://github.com/iterative/dvclive/issues/397) and consider in what scenarios DVCLive makes sense without DVC or a DVC repo. It may be better to require these generally rather than check for them for enabling each individual feature.

Let's discuss in the issue

[daavoo]

Closing in favor of #481