live: Add __enter__ and __exit__.
#354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
commented
Nov 3, 2022
daavoo
force-pushed
the
context-manager
branch
from
d5ac918 to
38f8f12
Compare
Call `make_summary` and `make_report` on `__exit__`.
daavoo
force-pushed
the
context-manager
branch
from
38f8f12 to
58681ad
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 1.0 #354 +/- ##
======================================
Coverage ? 93.33%
======================================
Files ? 36
Lines ? 1711
Branches ? 147
======================================
Hits ? 1597
Misses ? 90
Partials ? 24 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dberenbaum
approved these changes
Nov 4, 2022
dberenbaum
reviewed
Nov 4, 2022
Comment on lines
+266
to
+267
| def __exit__(self, exc_type, exc_val, exc_tb): | ||
| self.end() |
There was a problem hiding this comment.
Minor follow-up: let's either document end() or get rid of it and move the logic here. What do you think @daavoo?
There was a problem hiding this comment.
I slightly prefer getting rid of end() since I'm not sure it's worth adding to docs, but no strong preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for #353