Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live: Moved all make_{x} to next_step(). #353

Merged
merged 1 commit into from
Nov 4, 2022
Merged

live: Moved all make_{x} to next_step(). #353

merged 1 commit into from
Nov 4, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 3, 2022

log_metric now stores logged value in live.summary but doesn't call make_summary as before.

Closes #238
Closes #232

@daavoo daavoo requested a review from dberenbaum November 3, 2022 10:51
@daavoo
Copy link
Contributor Author

daavoo commented Nov 3, 2022 •
edited
Loading

@dberenbaum I think that #172 could be beneficial to better highlight that next_step is "special"

@daavoo daavoo force-pushed the revisit-next-step branch from 9950266 to 220697f Compare November 3, 2022 11:29
@daavoo daavoo mentioned this pull request Nov 3, 2022
Merged
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.0@81ee117). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@          Coverage Diff           @@
##             1.0     #353   +/-   ##
======================================
  Coverage       ?   95.08%           
======================================
  Files          ?       36           
  Lines          ?     1689           
  Branches       ?      145           
======================================
  Hits           ?     1606           
  Misses         ?       59           
  Partials       ?       24

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo
live: Moved all make_{x} to next_step().
ba0bbe0 
`log_metric` now stores logged value in `live.summary` but doesn't call `make_summary` as before.

Call `make_summary` inside `live.end`.

Closes #238
Closes #232
@daavoo daavoo force-pushed the revisit-next-step branch from 220697f to ba0bbe0 Compare November 3, 2022 17:19
@daavoo daavoo mentioned this pull request Nov 3, 2022
Closed
13 tasks
@daavoo daavoo merged commit f985113 into 1.0 Nov 4, 2022
@daavoo daavoo deleted the revisit-next-step branch November 4, 2022 08:39
daavoo added a commit that referenced this pull request Nov 4, 2022
@daavoo
live: Moved all make_{x} to next_step(). (#353)
a112581 
`log_metric` now stores logged value in `live.summary` but doesn't call `make_summary` as before.

Call `make_summary` inside `live.end`.

Closes #238
Closes #232
daavoo added a commit that referenced this pull request Nov 4, 2022
@daavoo
live: Moved all make_{x} to next_step(). (#353)
069f744 
`log_metric` now stores logged value in `live.summary` but doesn't call `make_summary` as before.

Call `make_summary` inside `live.end`.

Closes #238
Closes #232
@casperdcl
Copy link

casperdcl commented Nov 16, 2022 •
edited
Loading

Is there a docs PR somewhere for this? What's the before-and-after end-user code/UX?

(context: #232 (comment))

@casperdcl casperdcl mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daavoo @codecov-commenter @casperdcl @dberenbaum