log_sklearn_plot: Support custom name. #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
force-pushed
the
323-log_plot-custom-filename-andor-title-for-sklearn-plots
branch
from
c552d15 to
1054b0a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 1.0 #339 +/- ##
======================================
Coverage ? 94.96%
======================================
Files ? 36
Lines ? 1786
Branches ? 165
======================================
Hits ? 1696
Misses ? 65
Partials ? 25 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
One minor request: look for a |
Rename existing `name` argument to `kind`. This argument is used to determine the type of plot. Add new optional `name` argument to define output file. Closes #323
daavoo
force-pushed
the
323-log_plot-custom-filename-andor-title-for-sklearn-plots
branch
from
1054b0a to
1cfe551
Compare
should be done now |
daavoo
deleted the
323-log_plot-custom-filename-andor-title-for-sklearn-plots
branch
|
Nice, thanks! Is there a docs PR? |
I am grouping all 1.0 in a single branch |
|
Can we have separate PRs and merge into a similar dvclive-1.0 branch in dvc.org so we don't have one massive review? |
daavoo
added a commit
to iterative/dvc.org
that referenced
this pull request
Oct 26, 2022
daavoo
added a commit
to iterative/dvc.org
that referenced
this pull request
Oct 26, 2022
daavoo
added a commit
to iterative/dvc.org
that referenced
this pull request
Oct 27, 2022
daavoo
added a commit
to iterative/dvc.org
that referenced
this pull request
Oct 28, 2022
daavoo
added a commit
that referenced
this pull request
Oct 31, 2022
Rename existing `name` argument to `kind`. This argument is used to determine the type of plot. Add new optional `name` argument to define output file. Closes #323
daavoo
added a commit
that referenced
this pull request
Nov 4, 2022
Rename existing `name` argument to `kind`. This argument is used to determine the type of plot. Add new optional `name` argument to define output file. Closes #323
daavoo
added a commit
that referenced
this pull request
Nov 4, 2022
Rename existing `name` argument to `kind`. This argument is used to determine the type of plot. Add new optional `name` argument to define output file. Closes #323
daavoo
added a commit
to iterative/dvc.org
that referenced
this pull request
Nov 5, 2022
* initial refactor * Mention API Reference * Fix link * Add redirect * Update content/docs/dvclive/how-to/checkpoints.md Co-authored-by: Dave Berenbaum <[email protected]> * Remove how-to folder * Add outputs content * Reorder sidebar * Add tabs with popular frameworks * Remove outdated `dvclive with DVC` * clean * Add params * Clarify value without DVC * Update outputs to current status * Update content/docs/dvclive/get-started.md Co-authored-by: Dave Berenbaum <[email protected]> * Reduce wording * Add Python API tab * More details * Updates from review * Capitalize pages * Mention studio for sharing experiments * New section for Studio * Add sample output * Move ml-frameworks to api-refeference * Drop resume page * Apply suggestions from code review Co-authored-by: Dave Berenbaum <[email protected]> * Restyled by prettier (#4050) Co-authored-by: Restyled.io <[email protected]> * Suggestions from code review * caps * Add sections * Add example output * Add admon * Share experiment -> Share Results * Update output structure. Per iterative/dvclive#322 * Revisit output names * path -> dir * Add make_report call * Rename log -> log_metric * Update log_sklearn_plot. (#4074) Per iterative/dvclive#339 * Apply suggestions from code review Co-authored-by: Jorge Orpinel <[email protected]> * Replace dvc with cli * Remove tree * Update output dir in frameworks * grammarly * Revisit frameworks naming. * Remplaze `path` with `dir` * Rename `outputs` to `how-it-works` * Rename `Output Folder Structure` to `How it Works` * Rename Scalars to Metrics * Simplify `Live` Attributes description * Renamed folder to directory * Revisit `step` definition * Fix tree * Remove cat * Replace vscode plots with data series * Updates with new summary behavior and step property * Fix links * Consistent framework tabs * Update content/docs/dvclive/api-reference/live/log_metric.md * start: dvclive 1.0 updates to exp viz page * Update content/docs/start/experiment-management/visualization.md Co-authored-by: David de la Iglesia Castro <[email protected]> * Revisit dvclive usage outside doc/dvclive * Focus on context manager usage. * hint about next_step * Update content/docs/dvclive/api-reference/live/next_step.md Co-authored-by: Dave Berenbaum <[email protected]> * Link for `Live.metrics_file` * Restyled by prettier (#4097) Co-authored-by: Restyled.io <[email protected]> * Updates per iterative/example-repos-dev#143 Co-authored-by: Dave Berenbaum <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Jorge Orpinel <[email protected]> Co-authored-by: rogermparent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the existing
nameargument tokind. This argument is used to determine the type of plot. Add a new optionalnameargument to define the output file.Closes #323